ddragosd commented on a change in pull request #2531: Share bookkeeping data
across controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r139766795
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -95,7 +93,18 @@ class LoadBalancerService(config: WhiskConfig, instance:
InstanceId, entityStore
private val blackboxFraction: Double = Math.max(0.0, Math.min(1.0,
config.controllerBlackboxFraction))
logging.info(this, s"blackboxFraction =
$blackboxFraction")(TransactionId.loadbalancer)
- private val loadBalancerData = new LoadBalancerData()
+ /** Feature switch for shared load balancer data **/
+ private val loadBalancerData = {
+ if (config.controllerLocalBookkeeping) {
+ new LocalLoadBalancerData()
+ } else {
+
+ /** Specify how seed nodes are generated */
+ val seedNodesProvider = new
StaticSeedNodesProvider(config.controllerSeedNodes, actorSystem.name)
+ Cluster(actorSystem).joinSeedNodes(seedNodesProvider.getSeedNodes())
Review comment:
? @vvraskin . Right now we're assuming the LB is the show runner, which I
think it's true. We'll see more later when we get to separate the DataPlane(LB)
from the Control Plane ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
