rabbah commented on a change in pull request #2658: Treat a timed out active
ack as failed activation in invokerhealth protocol
URL:
https://github.com/apache/incubator-openwhisk/pull/2658#discussion_r140471537
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/InvokerSupervision.scala
##########
@@ -286,9 +286,10 @@ class InvokerActor(invokerInstance: InstanceId,
controllerInstance: InstanceId)
private def handleCompletionMessage(wasActivationSuccessful: Boolean,
buffer: RingBuffer[Boolean]) = {
buffer.add(wasActivationSuccessful)
- // If the current state is UnHealthy, then the active ack is the result of
a test action.
- // If this is successful it seems like the Invoker is Healthy again. So we
execute immediately
+ // If the action is successful it seems like the Invoker is Healthy again.
So we execute immediately
// a new test action to remove the errors out of the RingBuffer as fast as
possible.
+ // The actions that arrice while the invoker is unhealthy are most likely
health actions.
Review comment:
arrice -> arrive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
