rabbah commented on a change in pull request #2658: Treat a timed out active
ack as failed activation in invokerhealth protocol
URL:
https://github.com/apache/incubator-openwhisk/pull/2658#discussion_r140472071
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -125,18 +125,34 @@ class LoadBalancerService(config: WhiskConfig, instance:
InstanceId, entityStore
*/
private def processCompletion(response: Either[ActivationId,
WhiskActivation],
tid: TransactionId,
- forced: Boolean): Unit = {
+ forced: Boolean,
+ invoker: InstanceId): Unit = {
val aid = response.fold(l => l, r => r.activationId)
+
+ // treat left as success (as it is the result a the message exceeding the
bus limit)
+ // treat timed out active ack as failure to let the invoker become
unhealthy
+ val isSuccess = response.fold(l => true, r => !r.response.isWhiskError)
Review comment:
timed out active ack === forced.
but this fold does not account for the forced value.
comment inconsistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
