dgrove-oss commented on a change in pull request #2689: first stage of support
for dynamic invoker id assignment
URL:
https://github.com/apache/incubator-openwhisk/pull/2689#discussion_r141172768
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -48,18 +50,17 @@ object Invoker {
WhiskEntityStore.requiredProperties ++
WhiskActivationStore.requiredProperties ++
kafkaHost ++
+ redisHost ++
wskApiHost ++ Map(
dockerImageTag -> "latest",
invokerNumCore -> "4",
invokerCoreShare -> "2",
invokerContainerPolicy -> "",
invokerContainerDns -> "",
- invokerContainerNetwork -> null)
+ invokerContainerNetwork -> null) ++
+ Map(invokerName -> null)
Review comment:
sure. Do you think that is better? The previous map seems to be all docker
related things so I was keeping logical separation. Happy to do it either way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
