dgrove-oss commented on a change in pull request #2689: first stage of support
for dynamic invoker id assignment
URL:
https://github.com/apache/incubator-openwhisk/pull/2689#discussion_r141602338
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -85,6 +86,41 @@ object Invoker {
abort()
}
+ val proposedInvokerId: Option[Int] = args.headOption.map(_.toInt)
+ val assignedInvokerId = proposedInvokerId
+ .map { id =>
+ logger.info(this, s"invokerReg: using proposedInvokerId ${id}")
+ id
+ }
+ .getOrElse {
+ val invokerName = config.invokerName
Review comment:
@ServoKvd, I think I failed to actually post something about possible
followons to this PR. As Rodric said, this PR was meant as a small step to
allow us to decouple the invoker name from the kafka topic that the invoker is
assigned to service. Useful for some of the kube work and to give some
flexibility in deployment. In the future the decoupling could allow a fancier
load balancer that could more dynamically assign invokers to topics and also
support an elastic pool of invokers that could grow and shrink depending on
overall system load. All details still to be worked out ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
