tysonnorris commented on a change in pull request #62: added redis host for
invoker
URL:
https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146009799
##########
File path: docker-compose/docker-compose.yml
##########
@@ -81,12 +82,15 @@ services:
- ~/tmp/openwhisk/local.env # generated during make setup
environment:
COMPONENT_NAME: invoker
- SERVICE_NAME: invoker0
+ INVOKER_NAME: invoker0
Review comment:
2 things:
- it's fine to introduce redis usage from invoker if that is the goal, but
it's not required if you still pass the instance id at the invoker; for compose
env it may be simpler to NOT rely on redis from invoker so there is no risk of
startup timing issues (if invoker starts first and redis is NOT listening yet)
- if you DO want to rely on redis from invoker in compose env, I would give
the INVOKER_NAME something that is unlike the instance id naming approach, e.g.
`INVOKER_NAME: compose-invoker-1`, or similar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
