tysonnorris commented on a change in pull request #62: added redis host for 
invoker
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146999639
 
 

 ##########
 File path: docker-compose/docker-compose.yml
 ##########
 @@ -81,12 +82,15 @@ services:
       - ~/tmp/openwhisk/local.env     # generated during make setup
     environment:
       COMPONENT_NAME: invoker
-      SERVICE_NAME: invoker0
+      INVOKER_NAME: invoker0
 
 Review comment:
   Maybe this 
https://github.com/apache/incubator-openwhisk/blob/45e392e13fc7cd659e2a29b20ab070288412e200/core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala#L62
 
   should be changed to:
   ```Map(invokerName -> "")```
   @rabbah @dgrove-oss I assume the expected behavior is that NEITHER redis 
host NOR invoker name should be required configs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to