rabbah commented on a change in pull request #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146270132
########## File path: common/scala/transformEnvironment.sh ########## @@ -0,0 +1,32 @@ +#!/bin/bash + +prefix="CONFIG_" +configVariables=$(compgen -v | grep $prefix) + +props=() + +for var in $configVariables Review comment: can you add a comment that documents the contract now between settings in the conf files and their use in the code? maybe not necessarily in this file, but we should write it down somewhere. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
