rabbah commented on a change in pull request #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146269623
########## File path: core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala ########## @@ -86,11 +90,13 @@ class LoadBalancerService(config: WhiskConfig, instance: InstanceId, entityStore logging: Logging) extends LoadBalancer { + private val lbConfig = loadConfigOrThrow[LoadbalancerConfig]("whisk.loadbalancer") Review comment: will this abort the controller startup on throw? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services