jeremiaswerner commented on a change in pull request #2744: Deploy kafka &
zookeeper cluster with ansible
URL:
https://github.com/apache/incubator-openwhisk/pull/2744#discussion_r149990946
##########
File path: ansible/group_vars/all
##########
@@ -125,8 +125,9 @@ kafka:
version: 0.10.2.1
port: 9092
ras:
- port: 9093
+ port: 8093
heap: "{{ kafka_heap | default('1g') }}"
+ replicationFactor: 1
Review comment:
The `replicationFactor` is an important setting for the resiliency of the
kafka cluster. If it's set to `1` by default the system would not be resilient
against failures of a kafka node.
Therefore I would prefer to handle the `replicationFactor` in a way that we
can override it per environment similar to the `heap` setting above, i.e.
```
replicationFactor: {{ kafka_replicationFactor | default(1) }}
```
In a particular environment where we use multiple kafka nodes we would then
be able to override the replicationFactor accordingly. Also, I think that's in
general a good practice in our ansible playbooks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
