jeremiaswerner commented on a change in pull request #2744: Deploy kafka & 
zookeeper cluster with ansible
URL: 
https://github.com/apache/incubator-openwhisk/pull/2744#discussion_r151067356
 
 

 ##########
 File path: ansible/roles/kafka/tasks/clean.yml
 ##########
 @@ -3,16 +3,8 @@
 
 - name: remove kafka
 
 Review comment:
   just recognized an issue with rollout into existing environments and while 
testing it on PGs. While we do transition we should keep a clean step to remove 
`kafka` container. Since the new clean task would only clean `kafkaX` 
containers but leave `kafka` containers which could result in a port conflict.
   
   Proposal: pls keep a second `remove kafka` task in here. we could remove 
after some time. (same for zookeeper removal below)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to