csantanapr commented on a change in pull request #2969: Switch to use the
remote mode to install the binaries
URL:
https://github.com/apache/incubator-openwhisk/pull/2969#discussion_r151470303
##########
File path: ansible/group_vars/all
##########
@@ -303,16 +303,16 @@ openwhisk_cli_tag: "{{ lookup('ini', 'git_tag
section=openwhisk-cli file={{ open
# remote mode or location to save the binaries of the OpenWhisk CLI in local
mode.
#
+installation_mode: remote
Review comment:
Now that I look what you are doing I think we need more specific name and
also a way to override via en environment.
How about this:
```
cli_installation_mode_default: local
cli_installation_mode: "{{ openwhisk_cli_installation_mode |
default(cli_installation_mode_default) }}"
```
Then for example ins `environments/local/group_vars/all it can override via
```
openwhisk_cli_installation_mode: remote
```
In addition via cmd flag
```
ansible-playbook -i environments/local openwhisk.yml -e
cli_installation_mode=remote; to download binaries.
ansible-playbook -i environments/local openwhisk.yml -e
cli_installation_mode=local; to copy local binaries.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
