csantanapr commented on a change in pull request #2969: Switch to use the
remote mode to install the binaries
URL:
https://github.com/apache/incubator-openwhisk/pull/2969#discussion_r151472832
##########
File path: ansible/roles/cli/tasks/copy_local_openwhisk_cli.yml
##########
@@ -5,6 +5,20 @@
- local_action: stat path={{ openwhisk_cli.local.location }}/{{ item }}
register: binary_path
+- name: "ensure Nginx cli directory is writable"
+ file:
+ path: "{{ cli.nginxdir }}"
+ state: directory
+ mode: 0777
+ become: true
Review comment:
do not hardcode `become` use variable `cli.dir.become`
```
name: "ensure Nginx cli directory is writable"
file:
path: "{{ cli.nginxdir }}"
state: directory
mode: 0777
become: "{{ cli.dir.become }}"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
