mrutkows commented on issue #648: Examine use of NewYAMLFileFormat error
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/648#issuecomment-345322779
 
 
   The nested passing of one error (string) into another seems to be more than 
just this one error type
   
   ```
   $ grep -r ", err.Error())" . --include=*.go
   ./deployers/filesystemreader.go:                return 
utils.NewFileReadError(fpath, err.Error())
   ./deployers/filesystemreader.go:                            return 
utils.NewFileReadError(fpath, err.Error())
   ./deployers/filesystemreader.go:            return name, action, 
utils.NewFileReadError(filePath, err.Error())
   ./deployers/manifestreader.go:               return manifest, 
manifestParser, utils.NewFileReadError(dep.ManifestPath, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifest.Filepath, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:               return 
utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:                                       return 
utils.NewYAMLFileFormatError(depName, err.Error())
   ./deployers/manifestreader.go:                                       return 
utils.NewFileReadError(manifestAction.Filepath, err.Error())
   ./deployers/manifestreader.go:                               return 
utils.NewFileReadError(manifestAction.Filepath, err.Error())
   ./deployers/manifestreader.go:                               return 
utils.NewFileReadError(seqAction.Filepath, err.Error())
   ./deployers/servicedeployer.go:                      return 
utils.NewYAMLFileFormatError(manifest.Filepath, err.Error())
   ./parsers/deploy_parser.go:        return &dplyyaml, 
utils.NewFileReadError(deploymentPath, err.Error())
   ./parsers/manifest_parser.go:                        return &maniyaml, 
utils.NewFileReadError(utils.ManifestFileNameYaml, err.Error())
   ./parsers/manifest_parser.go:                return 
utils.NewYAMLFileFormatError(filename, err.Error())
   ./parsers/manifest_parser.go:                return 
utils.NewFileReadError(filename, err.Error())
   ./parsers/manifest_parser.go:                return &maniyaml, 
utils.NewFileReadError(manifestPath, err.Error())
   ./utils/errorhandlers.go:    fmt.Fprintf(outputStream, "%s%s", 
color.RedString(wski18n.T("Error: ")), err.Error())
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to