mrutkows commented on issue #648: Examine use of NewYAMLFileFormat error URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/648#issuecomment-346153385 As part of the fix, we will also address errors that were being created "ad-hoc" (in-line): ``` $ grep -r "errors.New" . --include=*.go ./cmd/root.go: return errors.New(wski18n.T("Missing cmd key")) ./deployers/deploymentreader.go: err := errors.New(wski18n.T("Annotation key \"" + name + "\" does not exist in manifest file but specified in deployment file.")) ./deployers/deploymentreader.go: err := errors.New(wski18n.T("Annotation key \"" + name + "\" does not exist in manifest file but specified in deployment file.")) ./deployers/deploymentreader.go: err := errors.New(wski18n.T("Annotation key \"" + name + "\" does not exist in manifest file but specified in deployment file.")) ./deployers/filesystemreader.go: return "", nil, errors.New("Unsupported action type.") ./deployers/filesystemreader.go: return errors.New("Conflict detected for action named " + existAction.Action.Name + ". Found two locations for source file: " + existAction.Filepath + " and " + fileAction.Filepath) ./deployers/manifestreader.go: err := errors.New("Package [" + pkg.Name + "] exists already.") ./deployers/manifestreader.go: err := errors.New("Conflict detected for action named " + ./deployers/manifestreader.go: err := errors.New("Action " + action.Action.Name + " has no source code location set.") ./deployers/manifestreader.go: err := errors.New("Error: Action " + action.Action.Name + " has no kind set") ./deployers/manifestreader.go: err := errors.New("Error: Action " + action.Action.Name + " has no source code") ./deployers/manifestreader.go: err := errors.New("manifestReader. Error: Conflict sequence action with an action. " + ./parsers/manifest_parser.go: return nil, errors.New("Dependency type is unknown. wskdeploy only supports /whisk.system bindings or github.com packages.") ./tests/src/integration/common/wskdeploy.go: return errors.New("Missing APIHost for wskprops.") ./tests/src/integration/common/wskdeploy.go: return errors.New("Missing Namespace for wskprops.") ./tests/src/integration/common/wskdeploy.go: return errors.New("Missing AuthKey for wskprops.") ./utils/misc.go: return errors.New(errMsg) ./utils/misc.go: return errors.New(errMsg) ./utils/misc.go: return errors.New(errMsg) ./utils/qualifiedname.go: err := errors.New("A valid qualified name was not detected") ./utils/qualifiedname.go: err := errors.New("A valid qualified name was not detected") ./utils/qualifiedname.go: err := errors.New("A valid qualified name was not detected") ./utils/webaction.go: return nil, errors.New(webMode) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
