markusthoemmes commented on a change in pull request #2991: controller creates 
health and cacheInvalidation topics
URL: 
https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r154941612
 
 

 ##########
 File path: common/scala/src/main/resources/kafka.conf
 ##########
 @@ -0,0 +1,24 @@
+kafka {
 
 Review comment:
   @dgrove-oss yep, there is: 
https://github.com/apache/incubator-openwhisk/blob/master/docs/dev/configuration.md
   
   We should maybe add that all openwhisk related configuration should go under 
"whisk" to prevent potential clashes with other modules (reactive kafka in this 
case).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to