mhamann commented on a change in pull request #269: add
PUBLIC_MANAGEDURL_CONNECT to override HOST:PORT assumption
URL:
https://github.com/apache/incubator-openwhisk-apigateway/pull/269#discussion_r158150554
##########
File path: scripts/lua/management/lib/apis.lua
##########
@@ -27,6 +27,8 @@ local MANAGEDURL_HOST = os.getenv("PUBLIC_MANAGEDURL_HOST")
MANAGEDURL_HOST = (MANAGEDURL_HOST ~= nil and MANAGEDURL_HOST ~= '') and
MANAGEDURL_HOST or "0.0.0.0"
local MANAGEDURL_PORT = os.getenv("PUBLIC_MANAGEDURL_PORT")
MANAGEDURL_PORT = (MANAGEDURL_PORT ~= nil and MANAGEDURL_PORT ~= '') and
MANAGEDURL_PORT or "8080"
+local MANAGEDURL_CONNECT = os.getenv("PUBLIC_MANAGEDURL_CONNECT")
Review comment:
I wonder if `PUBLIC_GATEWAY_URL` might be a better name for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
