mhamann commented on a change in pull request #269: add
PUBLIC_MANAGEDURL_CONNECT to override HOST:PORT assumption
URL:
https://github.com/apache/incubator-openwhisk-apigateway/pull/269#discussion_r158150474
##########
File path: scripts/lua/management/lib/apis.lua
##########
@@ -87,7 +89,7 @@ function _M.addAPI(dataStore, decoded, existingAPI)
basePath = basePath:sub(-1) == '/' and basePath:sub(1, -2) or basePath
-- Create managedUrl object
local uuid = existingAPI ~= nil and existingAPI.id or utils.uuid()
- local managedUrl = utils.concatStrings({"http://";, MANAGEDURL_HOST, ":",
MANAGEDURL_PORT, "/api/", decoded.tenantId})
+ local managedUrl = utils.concatStrings({"http://";, MANAGEDURL_CONNECT,
"/api/", decoded.tenantId})
Review comment:
With this change, you also shouldn't assume `http` only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
