jonpspri commented on a change in pull request #184: Create tarball for Nginx
container in OpenWhisk as part of release deploy script
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/184#discussion_r159436451
##########
File path: config/content.json
##########
@@ -0,0 +1,49 @@
+{
Review comment:
Yes, I think we can, but I'm not sure we want to. The key configuration
attributes are:
1. OS Architecture combination,
2. Filename for the tar file (with some interesting exception cases for
naming standards).
I like having 'content.json' driving the build, because configuration
directly drives content. We _could_ add one layer of indirection so we don't
manually maintain the directory structure and file names, but I'm not sure it's
worth the work given that this configuration seems unlikely to change
frequently. Thoughts from any/all?
I will look at build.sh and also at what's over in incubator-openwhisk. I
welcome further input from you and others, especially on cases for where the
Filename may need substitution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
