jonpspri commented on a change in pull request #184: Create tarball for Nginx
container in OpenWhisk as part of release deploy script
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/184#discussion_r159540811
##########
File path: config/content.json
##########
@@ -0,0 +1,49 @@
+{
Review comment:
@dubeejw Could you take a look at
https://github.com/jonpspri/incubator-openwhisk/blob/2f90600617803cff7c4cae7d8880c1cad8e12160/ansible/roles/cli/files/createContentJson.sh
? I essentially did there what would need to happen to build.sh in order to
generate content.json . In addtion, the arguments format for the docker build
would need to change. CLI_OS and CLI_ARCH as separate variables no longer
works because once you introduce the more esoteric architectures like s390x and
ppc64le, the build list is no longer a cartesian product of the two lists.
I've had to resort to lists of pairs instead to make the build work. The
reason I wasn't generating content.json is because it essentially IS that list
of pairs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
