mrutkows commented on a change in pull request #678: Parameterizing trigger name rule name as well as triggers and actions inside rule URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/678#discussion_r159536450
########## File path: tests/dat/manifest_data_rule_env_var.yaml ########## @@ -0,0 +1,14 @@ +# This test file is used to test the basic Trigger-Action-Rule grammar +packages: + manifest1: + version: 1.0 + license: Apache-2.0 + actions: + first_action: + function: actions/hello.js + triggers: + $trigger_name: + rules: + $rule_name: + trigger: $trigger_name + action: $action_name Review comment: $action_name replacement should be tested elsewhere? trigger-rule indeed belong together here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
