mrutkows commented on a change in pull request #678: Parameterizing trigger
name rule name as well as triggers and actions inside rule
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/678#discussion_r159536086
##########
File path: parsers/yamlparser.go
##########
@@ -177,16 +177,17 @@ func (yaml *YAML) GetProject() Project {
return yaml.Application
}
-func convertSinglePackageName(packageName string) string {
- if len(packageName) != 0 {
- packageNameEnv := wskenv.GetEnvVar(packageName)
- if str, ok := packageNameEnv.(string); ok {
+
+func convertSingleName(theName string) string {
Review comment:
Can you move this function to the package wskenv please? (i.e.,
wskenv/environment.go )?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
