rabbah commented on a change in pull request #3103: Rewrite wsk basic tests
URL:
https://github.com/apache/incubator-openwhisk/pull/3103#discussion_r161284315
##########
File path: tests/src/test/scala/system/basic/WskBasicTests.scala
##########
@@ -81,12 +83,13 @@ class WskBasicTests extends TestHelpers with
WskTestHelpers {
pkg.create(name, parameters = params, shared = Some(true))
pkg.create(name, update = true)
}
- val stdout = wsk.pkg.get(name).stdout
- stdout should include regex (""""key": "a"""")
- stdout should include regex (""""value": "A"""")
- stdout should include regex (""""publish": true""")
- stdout should include regex (""""version": "0.0.2"""")
- wsk.pkg.list().stdout should include(name)
+ val pack = wsk.pkg.get(name)
+ pack.getFieldJsValue("publish").toString shouldBe "true"
Review comment:
you can remove toString and use shouldBe JsBoolean(true) also fyi.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
