rabbah commented on a change in pull request #3103: Rewrite wsk basic tests
URL:
https://github.com/apache/incubator-openwhisk/pull/3103#discussion_r163135583
##########
File path: tests/src/test/scala/system/basic/WskBasicTests.scala
##########
@@ -552,19 +582,17 @@ class WskBasicTests extends TestHelpers with
WskTestHelpers {
val expectedParam = JsObject("payload" -> JsString("test"))
val ns = wsk.namespace.whois()
- wsk.trigger
+ val result = wsk.trigger
.get(name, fieldFilter = Some("namespace"))
- .stdout should include regex (s"""(?i)$successMsg namespace\n"$ns"""")
- wsk.trigger.get(name, fieldFilter = Some("name")).stdout should
include(s"""$successMsg name\n"$name"""")
- wsk.trigger.get(name, fieldFilter = Some("version")).stdout should
include(s"""$successMsg version\n"0.0.1"""")
- wsk.trigger.get(name, fieldFilter = Some("publish")).stdout should
include(s"""$successMsg publish\nfalse""")
- wsk.trigger.get(name, fieldFilter = Some("annotations")).stdout should
include(s"""$successMsg annotations\n[]""")
- wsk.trigger
- .get(name, fieldFilter = Some("parameters"))
- .stdout should include regex (s"""$successMsg
parameters\n\\[\\s+\\{\\s+"key":\\s+"payload",\\s+"value":\\s+"test"\\s+\\}\\s+\\]""")
- wsk.trigger.get(name, fieldFilter = Some("limits")).stdout should
include(s"""$successMsg limits\n{}""")
- wsk.trigger.get(name, fieldFilter = Some("invalid"), expectedExitCode =
ERROR_EXIT).stderr should include(
- "error: Invalid field filter 'invalid'.")
+ result.getField("namespace") shouldBe ns
+ result.getField("name") shouldBe name
+ result.getField("version") shouldBe "0.0.1"
+ result.getFieldJsValue("publish") shouldBe JsBoolean(false)
+ result.getFieldJsValue("annotations").toString shouldBe "[]"
+ result.getFieldJsValue("parameters") shouldBe JsArray(
+ JsObject("key" -> JsString("payload"), "value" -> JsString("test")))
+ result.getFieldJsValue("limits").toString shouldBe "{}"
Review comment:
i think you can replace all the {} checks with JsObject()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
