markusthoemmes commented on a change in pull request #3211: implement
ContainerFactory.cpuShare to fix #3110
URL:
https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163773800
##########
File path: ansible/roles/invoker/tasks/deploy.yml
##########
@@ -173,8 +173,8 @@
{% for item in (invoker_container_network_dns_servers |
default()).split(' ') %}
-e
CONFIG_whisk_containerFactory_containerArgs_dnsServers_{{loop.index0}}={{ item
}}
{% endfor %}
- -e INVOKER_NUMCORE='{{ invoker.numcore }}'
- -e INVOKER_CORESHARE='{{ invoker.coreshare }}'
+ -e CONFIG_whisk_containerFactory_containerArgs_numCore='{{
invoker.numcore }}'
+ -e CONFIG_whisk_containerFactory_containerArgs_coreShare='{{
invoker.coreshare }}'
Review comment:
Its main purpose is to determine the maximum amount of containers to spawn.
Secondarily, that value is used to also determine the cpushares parameter, but
the main purpose is to tell the containerpool: How many cores and how do you
want to split them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
