markusthoemmes commented on a change in pull request #3211: implement
ContainerFactory.cpuShare to fix #3110
URL:
https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170877953
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFactory.scala
##########
@@ -67,13 +70,13 @@ class DockerContainerFactory(config: WhiskConfig,
image = image,
userProvidedImage = userProvidedImage,
memory = memory,
- cpuShares = config.invokerCoreShare.toInt,
+ cpuShares = poolConfig.cpuShare,
Review comment:
Should we widen the interface of `createContainer` by `cpuShares: Int` and
leave it to the ContainerPool to pass that value down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
