mrutkows commented on a change in pull request #738: GH-735 adjusting check for github to mainly make sure that github app? URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/738#discussion_r168261593
########## File path: utils/dependencies_test.go ########## @@ -0,0 +1,55 @@ +// +build unit + +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package utils + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestLocationIsGithub(t *testing.T) { + assert.True(t, LocationIsGithub("github.com/my-org/my-project"), "Does not allow github without a http/https prefix") + assert.True(t, LocationIsGithub("github.ibm.com/my-org/my-project"), "Does not allow github.ibm.com without a http/https prefix") + assert.True(t, LocationIsGithub("http://github.com/my-org/my-project";), "Does not allow github with a http/https prefix") + assert.True(t, LocationIsGithub("http://github.ibm.com/my-org/my-project";), "Does not allow github.ibm.com with a http/https prefix") +} + +func TestLocationIsGithub_WithUsernamePassword(t *testing.T) { + assert.True(t, LocationIsGithub("username:passw...@github.com/my-org/my-project"), "Does not allow username/password and github without a http/https prefix") Review comment: This is new functionality... the working assumption for wskdeploy was it would work with public repos. only. So this PR is a feature request. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
