markusthoemmes commented on a change in pull request #3343: Support time-series
DB using Kamon Tag, and optional granular metric.
URL:
https://github.com/apache/incubator-openwhisk/pull/3343#discussion_r170420944
##########
File path: common/scala/src/main/scala/whisk/common/Logging.scala
##########
@@ -164,27 +164,34 @@ private object Logging {
if (simpleName.endsWith("$")) simpleName.dropRight(1)
else simpleName
}
-
}
private object Emitter {
val timeFormat =
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").withZone(ZoneId.of("UTC"))
}
-case class LogMarkerToken(component: String, action: String, state: String) {
+case class LogMarkerToken(component: String,
Review comment:
A ScalaDoc comment here would be great, stating that `macroTags` should be
used for tags with a bounded number of permutations only while microTags can be
used for whatever granularity you might need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
