markusthoemmes commented on a change in pull request #3343: Support time-series
DB using Kamon Tag, and optional granular metric.
URL:
https://github.com/apache/incubator-openwhisk/pull/3343#discussion_r170420980
##########
File path: common/scala/src/main/scala/whisk/common/Logging.scala
##########
@@ -259,11 +269,16 @@ object LoggingMarkers {
// Time in invoker
val INVOKER_ACTIVATION = LogMarkerToken(invoker, activation, start)
- def INVOKER_DOCKER_CMD(cmd: String) = LogMarkerToken(invoker,
s"docker.$cmd", start)
- def INVOKER_RUNC_CMD(cmd: String) = LogMarkerToken(invoker, s"runc.$cmd",
start)
- def INVOKER_CONTAINER_START(containerState: String) =
- LogMarkerToken(invoker, s"container_start_${containerState}", count)
- def INVOKER_KUBECTL_CMD(cmd: String) = LogMarkerToken(invoker,
s"kubectl.$cmd", start)
+ def INVOKER_DOCKER_CMD(cmd: String) = LogMarkerToken(invoker, "docker",
start, Map("cmd" -> cmd))
+ def INVOKER_RUNC_CMD(cmd: String) = LogMarkerToken(invoker, "runc", start,
Map("cmd" -> cmd))
+ def INVOKER_KUBECTL_CMD(cmd: String) = LogMarkerToken(invoker, s"kubectl",
start, Map("cmd" -> cmd))
+ def INVOKER_CONTAINER_START(containerState: String, namespaceName: String,
actionName: String) =
+ LogMarkerToken(
+ invoker,
+ s"containerStart",
Review comment:
No string interpolation needed. Just `containerStart` is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
