bwmcadams commented on a change in pull request #3338: implement suspend/resume
for KubernetesContainer
URL:
https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171044427
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesContainer.scala
##########
@@ -57,10 +57,10 @@ object KubernetesContainer {
image: String,
userProvidedImage: Boolean = false,
memory: ByteSize = 256.MB,
- environment: Map[String, String] = Map(),
- labels: Map[String, String] = Map())(implicit kubernetes:
KubernetesApi,
- ec: ExecutionContext,
- log: Logging):
Future[KubernetesContainer] = {
+ environment: Map[String, String] = Map.empty,
+ labels: Map[String, String] = Map.empty)(implicit kubernetes:
KubernetesApi,
Review comment:
?
I much prefer `Map.empty` as it, in my eyes, is cleared reading wise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
