bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171042727
########## File path: core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala ########## @@ -41,17 +45,19 @@ import whisk.core.ConfigKeys import whisk.core.containerpool.ContainerId import whisk.core.containerpool.ContainerAddress import whisk.core.containerpool.docker.ProcessRunner +import whisk.core.entity.ByteSize +import whisk.core.entity.size._ import scala.concurrent.duration.Duration import scala.concurrent.ExecutionContext import scala.concurrent.Future import scala.concurrent.blocking -import scala.concurrent.duration._ import scala.util.Failure import scala.util.Success import scala.util.Try import spray.json._ import spray.json.DefaultJsonProtocol._ +import collection.JavaConversions._ Review comment: Agreed on this one; I'm not a fan of "magic" when it comes to collection behavior. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
