rabbah commented on a change in pull request #3199: One tid for the whole 
system.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182921617
 
 

 ##########
 File path: 
tests/src/test/scala/whisk/core/controller/test/PackagesApiTests.scala
 ##########
 @@ -750,7 +750,6 @@ class PackagesApiTests extends ControllerTestCommon with 
WhiskPackagesApi {
       status should be(Conflict)
       val response = responseAs[ErrorResponse]
       response.error should include("Package not empty (contains 1 entity)")
-      response.code.id should be >= 1L
 
 Review comment:
   Can you change this check to assert the id is not empty? This weakens the 
test to where a missing id is accepted. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to