rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182920863
##########
File path: ansible/group_vars/all
##########
@@ -96,8 +96,10 @@ jmx:
jvmCommonArgs: "-Dcom.sun.management.jmxremote
-Dcom.sun.management.jmxremote.ssl=false
-Dcom.sun.management.jmxremote.local.only=false
-Dcom.sun.management.jmxremote.authenticate=true
-Dcom.sun.management.jmxremote.password.file=/root/jmxremote.password
-Dcom.sun.management.jmxremote.access.file=/root/jmxremote.access"
enabled: "{{ jmxremote_enabled | default('true') }}"
-transactions:
- stride: "{{ groups['controllers'] | length }}"
+transaction:
+ header: "{{ transaction_header | default('X-Request-ID') }}"
+ # The tid can be any String between 1 and 64 characters.
+ regex: "{{ whisk_tid_regex | default('[a-zA-Z0-9_-]{1,64}') }}"
Review comment:
excluding - would make it easier to copy/paste a code (the dash breaks
double click to highlight a string).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services