markusthoemmes commented on a change in pull request #3694: Add retries to CLI 
test framework for network errors
URL: 
https://github.com/apache/incubator-openwhisk/pull/3694#discussion_r191120549
 
 

 ##########
 File path: tests/src/test/scala/common/TestUtils.java
 ##########
 @@ -54,11 +54,12 @@
 public class TestUtils {
     protected static final Logger logger = Logger.getLogger("basic");
 
-    public static final int SUCCESS_EXIT    = 0;
-    public static final int ERROR_EXIT      = 1;
-    public static final int MISUSE_EXIT     = 2;
-    public static final int DONTCARE_EXIT   = -1;       // any value is ok
-    public static final int ANY_ERROR_EXIT  = -2;       // any non-zero value 
is ok
+    public static final int SUCCESS_EXIT        = 0;
+    public static final int ERROR_EXIT          = 1;
+    public static final int MISUSE_EXIT         = 2;
+    public static final int DONTCARE_EXIT       = -1;       // any value is ok
+    public static final int ANY_ERROR_EXIT      = -2;       // any non-zero 
value is ok
+    public static final int NETWORK_ERROR_EXIT  = 3;
 
 Review comment:
   Which errors are part of this? Does the CLI return a "3" on network issues 
as a convention?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to