markusthoemmes commented on issue #3694: Add retries to CLI test framework for 
network errors
URL: 
https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-392432032
 
 
   General existential question: I'm unclear if this changes any semantics in 
our tests. The main issue I could see (and I'm not sure if its really a 
problem) is that our requests are not necessarily idempotent. That is: A 
connection error might happen at any stage of the connection so you'll never 
know if it's safe to retry.
   
   This might still make things better but it could certainly harm 
debuggability in tests. It might make sense to add a logline stating it's 
retrying because of a network issue to be able to tell later if an 
inconsistency was caused by that. Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to