markusthoemmes commented on a change in pull request #3619: Provide an
activation store SPI
URL:
https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r190142032
##########
File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala
##########
@@ -35,7 +35,7 @@ import scala.util.{Failure, Success, Try}
*
* @param asString the activation id
*/
-protected[whisk] class ActivationId private (val asString: String) extends
AnyVal {
+protected[whisk] case class ActivationId private (val asString: String)
extends AnyVal {
Review comment:
I think this breaks the neat non-allocating behavior of ActivationId. I'm
not sure if that is broken today already though. See:
https://www.scala-lang.org/api/2.12.x/scala/AnyVal.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services