markusthoemmes commented on a change in pull request #3619: Provide an
activation store SPI
URL:
https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r194629893
##########
File path:
core/controller/src/main/scala/whisk/core/controller/Activations.scala
##########
@@ -159,40 +157,16 @@ trait WhiskActivationsApi extends Directives with
AuthenticatedRouteProvider wit
'upto.as[Instant] ?) { (skip, limit, count, docs, name, since, upto) =>
if (count && !docs) {
countEntities {
- WhiskActivation.countCollectionInNamespace(
- activationStore,
- name.flatten.map(p => namespace.addPath(p)).getOrElse(namespace),
- skip.n,
- since,
- upto,
- StaleParameter.UpdateAfter,
- viewName = name.flatten.map(_ =>
WhiskActivation.filtersView).getOrElse(WhiskActivation.view))
+ activationStore.countActivationsInNamespace(name.flatten, namespace,
skip.n, since, upto)
Review comment:
That's because of
`'name.as[Option[EntityPath]] ?` which makes the Option optionable. @rabbah
any reason why this is the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services