markusthoemmes commented on a change in pull request #2795: enable concurrent
activation processing
URL:
https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r193304886
##########
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala
##########
@@ -725,7 +824,9 @@ class ContainerProxyTests
/**
* Implements all the good cases of a perfect run to facilitate error case
overriding.
*/
- class TestContainer extends Container {
+ class TestContainer(initPromise: Option[Promise[Interval]] = None,
+ runPromises: Option[Seq[Promise[(Interval,
ActivationResponse)]]] = None)
Review comment:
Should this be just a `Seq` rather than `Option[Seq]` and default to
`Seq.empty`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
