markusthoemmes commented on a change in pull request #2795: enable concurrent
activation processing
URL:
https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r193306609
##########
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala
##########
@@ -438,4 +449,16 @@ class ContainerPoolObjectTests extends FlatSpec with
Matchers with MockFactory {
ContainerPool.remove(pool) shouldBe Some('oldest)
}
+
+ it should "provide oldest container (excluding concurrently busy) from busy
pool with multiple containers" in {
+ val commonNamespace = differentNamespace.asString
+ val first = warmedData(namespace = commonNamespace, lastUsed =
Instant.ofEpochMilli(1), active = 0)
+ val second = warmedData(namespace = commonNamespace, lastUsed =
Instant.ofEpochMilli(2), active = 0)
+ val oldest = warmedData(namespace = commonNamespace, lastUsed =
Instant.ofEpochMilli(0), active = 3)
+
+ var pool = Map('first -> first, 'second -> second, 'oldest -> oldest)
Review comment:
Is a variable needed here? Can this be `val`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
