markusthoemmes commented on a change in pull request #2795: enable concurrent
activation processing
URL:
https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r193961152
##########
File path:
common/scala/src/main/scala/whisk/core/containerpool/ContainerFactory.scala
##########
@@ -31,7 +31,12 @@ case class ContainerArgsConfig(network: String,
dnsServers: Seq[String] = Seq.empty,
extraArgs: Map[String, Set[String]] = Map.empty)
-case class ContainerPoolConfig(numCore: Int, coreShare: Int) {
+case class ContainerPoolConfig(numCore: Int,
+ coreShare: Int,
+ maxConcurrent: Int = 1,
+ concurrentPeekFactor: Double = 0.5) {
Review comment:
Please don't define defaults in code. That will lead to multiple cases where
defaults are applied which will rot over time. The ones in `application.conf`
should be enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
