markusthoemmes commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r194047248
########## File path: common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.entity + +import spray.json.DefaultJsonProtocol + +case class InvokerInstanceId(val instance: Int, name: Option[String] = None) { + def toInt: Int = instance +} + +case class ControllerInstanceId(private val instance: String) { Review comment: Should it be a [value class](https://docs.scala-lang.org/overviews/core/value-classes.html) then? Would give us the benefit of 0 allocation. Code would translate to: ```scala class ControllerInstanceId(val asString: String) extends AnyVal ``` I'm wondering if we should fail out early if the controller name containers bad characters vs. implicitly removing them. Any bad characters that kube/mesos add by default? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
