markusthoemmes commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r197593919
##########
File path:
tests/src/test/scala/whisk/core/entity/test/ControllerInstanceIdTests.scala
##########
@@ -15,14 +15,32 @@
* limitations under the License.
*/
-package whisk.core.entity
+package whisk.core.entity.test
-import spray.json.DefaultJsonProtocol
+import org.junit.runner.RunWith
+import org.scalatest.FlatSpec
+import org.scalatest.Matchers
+import org.scalatest.junit.JUnitRunner
+import whisk.core.entity.ControllerInstanceId
-case class InstanceId(val instance: Int, name: Option[String] = None) {
- def toInt: Int = instance
-}
+@RunWith(classOf[JUnitRunner])
+class ControllerInstanceIdTests extends FlatSpec with Matchers {
+
+ behavior of "StringInstanceId"
Review comment:
Should be `behavior of "ControllerInstanceId"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
