tysonnorris commented on a change in pull request #41: remove use of state in
nodejs app
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#discussion_r197587911
##########
File path:
tests/src/test/scala/runtime/actionContainers/NodeJsActionContainerTests.scala
##########
@@ -547,4 +547,48 @@ abstract class NodeJsActionContainerTests extends
BasicActionRunnerTests with Ws
e shouldBe empty
})
}
+
+ it should "allow running activations concurrently" in {
+ val (out, err) = withNodeJsContainer { c =>
+ //this action will create a log entry, and only complete once all
activations have arrived and emitted logs
+ val code =
+ s"""
+ | global.count = 0;
+ | function main(args) {
+ | global.count++;
+ | console.log("interleave me");
+ | return new Promise(function(resolve, reject) {
+ | setTimeout(function() {
+ | if (global.count == 2) {
Review comment:
Me too - there is however something fishy about travis builds that failed if
this was greater than 2; the same tests work great locally. Do you have any
ideas on replicating that env? Should vagrant local be the closest thing? I
assume this is some difference in the behavior of http client (in HttpUtils)
that is somehow not allowing the extra connections (or maybe limited number of
threads for concurrent future processing?) that only shows in travis...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
