tysonnorris commented on a change in pull request #41: remove use of state in
nodejs app
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#discussion_r206345221
##########
File path: core/nodejsActionBase/src/service.js
##########
@@ -112,10 +113,14 @@ function NodeActionService(config) {
*/
this.runCode = function runCode(req) {
if (status === Status.ready) {
- setStatus(Status.running);
+ if (!ignoreRunStatus) {
+ setStatus(Status.running);
Review comment:
I don't think that we want to ignore status in all cases, only when we are
setting/testing `Status.running`. This seemed less confusing, with that in mind
- WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
