markusthoemmes commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-399617489 In a quick discussion with @rabbah, he made the very valid argument that my solution would only check for InstanceIds generated by the `main` method, but you'd be free to create other InstanceIds as you please. Something to chew on (but not for this pull-request): Instead of passing the ControllerInstanceId down to the invoker, we should rather somewhere convert it to `KafkaTopic` and pass that down as `resultTopic`, because that's what the invoker really cares about, it doesn't care it's a controller (I believe). Something for a later PR, I'm fine with this as-is! 🎉
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
