rabbah commented on a change in pull request #348: Update cli to fail
create/update sequences with limits
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/348#discussion_r200529360
##########
File path: commands/action.go
##########
@@ -424,6 +424,11 @@ func parseAction(cmd *cobra.Command, args []string,
update bool) (*whisk.Action,
return nil, whisk.MakeWskError(errors.New(errStr),
whisk.NOT_ALLOWED, whisk.DISPLAY_MSG, whisk.NO_DISPLAY_USAGE)
}
+ if (Flags.action.sequence && (cmd.LocalFlags().Changed(MEMORY_FLAG) ||
cmd.LocalFlags().Changed(LOG_SIZE_FLAG) ||
cmd.LocalFlags().Changed(TIMEOUT_FLAG))) {
+ errStr := wski18n.T("A sequence cannot have a memory limit, a log
size limit or a timeout limit.")
Review comment:
Can we transition to using message identifiers instead as in
https://github.com/apache/incubator-openwhisk-cli/blob/master/commands/messages.go#L26.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
