rabbah commented on a change in pull request #348: Update cli to fail 
create/update sequences with limits
URL: 
https://github.com/apache/incubator-openwhisk-cli/pull/348#discussion_r200529489
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
 ##########
 @@ -173,6 +173,48 @@ class WskCliBasicUsageTests extends TestHelpers with 
WskTestHelpers {
                       expectedExitCode = MISUSE_EXIT)
   }
 
+  it should "reject create or update of an action sequence that sets a memory 
limit" in withAssetCleaner(wskprops) { (wp, assetHelper) =>
 
 Review comment:
   all of these might be better suited as go unit tests - i think it makes 
sense to start adding new tests that are strictly testing the CLI in go.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to