chetanmeh commented on a change in pull request #3882: Use invoker id for
metrics instead of the hostname.
URL:
https://github.com/apache/incubator-openwhisk/pull/3882#discussion_r202895597
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -125,6 +124,14 @@ object Invoker {
new
InstanceIdAssigner(config.zookeeperHosts).getId(invokerUniqueName.get)
}
+
+ // Replace the hostname of the invoker to the assigned id of the invoker.
+ val newKamonConfig = Kamon.config
Review comment:
Nit can this be refactored to a method `initKamon(hostId:String)`. Further
should this be moved to a util method in `whisk.common` such it is also used in
Controller which also has this notion of id to identify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
