chetanmeh commented on a change in pull request #3882: Use invoker id for
metrics instead of the hostname.
URL:
https://github.com/apache/incubator-openwhisk/pull/3882#discussion_r202908636
##########
File path: common/scala/src/main/scala/whisk/common/Logging.scala
##########
@@ -212,6 +214,15 @@ object MetricEmitter {
val metrics = Kamon.metrics
Review comment:
Not sure if it would be safe to add to `MetricEmitter` as first reference to
`MetricEmitter` object itself would trigger loading of `metrics` and we would
probably need to have config provided and Kamon started before that happens.
So would be safer to have a new object hosting this method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
