sven-lange-last commented on a change in pull request #3835: Limit of binary actions is too low. URL: https://github.com/apache/incubator-openwhisk/pull/3835#discussion_r203051278
########## File path: ansible/roles/controller/tasks/deploy.yml ########## @@ -124,6 +124,10 @@ "COMPONENT_NAME": "{{ controller_name }}" "PORT": 8080 + # Allow base64 overhead of action-code, parameters and annotations. + "CONFIG_akka_http_server_parsing_maxContentLength": "{{ (limits.actionCodeMb | int * 4 / 3 + limits.parametersMb | int * 2) | round(0, 'ceil') | int }}m" Review comment: It may be valuable to add a comment that this setting does only consider the `code`, `parameters` and `annotations` parts in JSON messages because these are potentially the largest parts. If somebody uses very large values for code, a long `name` value may still overflow the message body. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services